pingnet: Fix ResourceWarning

2017-04-06 10:51:14 -05:00
parent ef6d435d8d
commit 10e5548513
1 changed files with 5 additions and 4 deletions
--- a/pingnet.py
+++ b/pingnet.py
@@ -64,10 +64,11 @@ class Pinger(threading.Thread):
                break

    def ping(self, host):
-        p = subprocess.Popen(['ping', '-c', '1', '-W', '1', host],
-                             stdin=open(os.devnull),
-                             stdout=open(os.devnull, 'w'),
-                             stderr=subprocess.STDOUT)
+        with open(os.devnull, 'r+') as nul:
+            p = subprocess.Popen(['ping', '-c', '1', '-W', '1', host],
+                                 stdin=nul,
+                                 stdout=nul,
+                                 stderr=subprocess.STDOUT)
        p.wait()
        if p.returncode == 0:
            if not self.quiet: