From fffa11a425e6bac11bff3812579b22d457e0491a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Barrag=C3=A1n=20Merino?=
 <david.barragan@kaleidos.net>
Date: Mon, 4 Aug 2014 17:56:52 +0200
Subject: [PATCH] Bamedize some unnecesary confirm.notify messages

---
 app/coffee/modules/admin/memberships.coffee  | 6 ++----
 app/coffee/modules/admin/roles.coffee        | 6 ++----
 app/coffee/modules/common/attachments.coffee | 2 --
 3 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/app/coffee/modules/admin/memberships.coffee b/app/coffee/modules/admin/memberships.coffee
index 4a618e63..519c9977 100644
--- a/app/coffee/modules/admin/memberships.coffee
+++ b/app/coffee/modules/admin/memberships.coffee
@@ -284,8 +284,7 @@ MembershipsRowAdminCheckboxDirective = ($log, $repo, $confirm) ->
             $el.find(":checkbox").prop("checked", true)
 
         $el.on "click", ":checkbox", (event) =>
-            onSuccess = ->
-                $confirm.notify("success")
+            onSuccess = null
 
             onError = ->
                 $confirm.notify("error")
@@ -335,8 +334,7 @@ MembershipsRowRoleSelectorDirective = ($log, $repo, $confirm) ->
         html = render(member)
 
         $el.on "click", "select", (event) =>
-            onSuccess = ->
-                $confirm.notify("success")
+            onSuccess = null
 
             onError = ->
                 $confirm.notify("error")
diff --git a/app/coffee/modules/admin/roles.coffee b/app/coffee/modules/admin/roles.coffee
index 6281e1c4..0ecbd2ca 100644
--- a/app/coffee/modules/admin/roles.coffee
+++ b/app/coffee/modules/admin/roles.coffee
@@ -91,12 +91,11 @@ class RolesController extends mixOf(taiga.Controller, taiga.PageMixin, taiga.Fil
                 @confirm.notify('error')
 
     setComputable: ->
-        onSuccess = (role) =>
-            @confirm.notify('success')
+        onSuccess = null
 
         onError = =>
             @confirm.notify("error")
-            @scope.role.computable = !@scope.role.computable
+            @scope.role.revert()
 
         @repo.save(@scope.role).then onSuccess, onError
 
@@ -303,7 +302,6 @@ RolePermissionsDirective = ($repo, $confirm) ->
                 $scope.role.permissions = getActivePermissions()
 
                 onSuccess = (role) ->
-                    $confirm.notify('success')
                     categories = generateCategoriesFromRole(role)
                     categoryId = target.parents(".category-config").data("id")
                     renderResume(target.parents(".category-config"), categories[categoryId])
diff --git a/app/coffee/modules/common/attachments.coffee b/app/coffee/modules/common/attachments.coffee
index 94ac90d0..61a98694 100644
--- a/app/coffee/modules/common/attachments.coffee
+++ b/app/coffee/modules/common/attachments.coffee
@@ -258,7 +258,6 @@ AttachmentDirective = ($log, $repo, $confirm) ->
 
             onSuccess = ->
                 $ctrl.onDeleteAttachment(attachment)
-                $confirm.notify("success", null, "We've deleted #{subtitle}.") #TODO: i18in
 
             onError = ->
                 $confirm.notify("error", null, "We have not been able to delete #{subtitle}.") #TODO: i18in
@@ -283,7 +282,6 @@ AttachmentDirective = ($log, $repo, $confirm) ->
             onSuccess = ->
                 $ctrl.onEditAttachment(attachment)
                 render(attachment)
-                $confirm.notify("success")
 
             onError = ->
                 $confirm.notify("error")