From 8627071f436dc57c2ac445945ba37cf9bcf7e995 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Barrag=C3=A1n=20Merino?= Date: Fri, 24 Oct 2014 13:50:19 +0200 Subject: [PATCH] Add loading spiner to the issue detail page --- app/coffee/app.coffee | 2 +- app/coffee/modules/issues/detail.coffee | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/coffee/app.coffee b/app/coffee/app.coffee index 5ed21f82..351b2bd1 100644 --- a/app/coffee/app.coffee +++ b/app/coffee/app.coffee @@ -69,7 +69,7 @@ configure = ($routeProvider, $locationProvider, $httpProvider, $provide, $tgEven $routeProvider.when("/project/:pslug/issues", {templateUrl: "/partials/issues.html", resolve: {loader: tgLoaderProvider.add()}}) $routeProvider.when("/project/:pslug/issue/:issueref", - {templateUrl: "/partials/issues-detail.html"}) + {templateUrl: "/partials/issues-detail.html", resolve: {loader: tgLoaderProvider.add()}}) # Admin $routeProvider.when("/project/:pslug/admin/project-profile/details", diff --git a/app/coffee/modules/issues/detail.coffee b/app/coffee/modules/issues/detail.coffee index 6388eda7..b4377fd6 100644 --- a/app/coffee/modules/issues/detail.coffee +++ b/app/coffee/modules/issues/detail.coffee @@ -46,11 +46,12 @@ class IssueDetailController extends mixOf(taiga.Controller, taiga.PageMixin) "$log", "$appTitle", "$tgAnalytics", - "$tgNavUrls" + "$tgNavUrls", + "tgLoader" ] constructor: (@scope, @rootscope, @repo, @confirm, @rs, @params, @q, @location, - @log, @appTitle, @analytics, @navUrls) -> + @log, @appTitle, @analytics, @navUrls, tgLoader) -> @scope.issueRef = @params.issueref @scope.sectionName = "Issue Details" @.initializeEventHandlers() @@ -60,6 +61,7 @@ class IssueDetailController extends mixOf(taiga.Controller, taiga.PageMixin) # On Success promise.then => @appTitle.set(@scope.issue.subject + " - " + @scope.project.name) + tgLoader.pageLoaded() # On Error promise.then null, @.onInitialDataError.bind(@)