From 7c41b02faf7090aeece060e459c0eb81b4b4b671 Mon Sep 17 00:00:00 2001 From: Juanfran Date: Tue, 26 May 2015 13:26:34 +0200 Subject: [PATCH] fix lighboxFactory close --- app/coffee/modules/projects/lightboxes.coffee | 2 ++ app/modules/services/lightbox-factory.service.coffee | 3 ++- app/modules/services/lightbox-factory.service.spec.coffee | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/coffee/modules/projects/lightboxes.coffee b/app/coffee/modules/projects/lightboxes.coffee index f4f36574..71951463 100644 --- a/app/coffee/modules/projects/lightboxes.coffee +++ b/app/coffee/modules/projects/lightboxes.coffee @@ -131,6 +131,8 @@ CreateProject = ($rootscope, $repo, $confirm, $location, $navurls, $rs, $project openLightbox() + console.log "link" + directive = { link: link, templateUrl: "project/wizard-create-project.html" diff --git a/app/modules/services/lightbox-factory.service.coffee b/app/modules/services/lightbox-factory.service.coffee index cd5d885c..9698fe27 100644 --- a/app/modules/services/lightbox-factory.service.coffee +++ b/app/modules/services/lightbox-factory.service.coffee @@ -8,11 +8,12 @@ class LightboxFactory elm = $("
") .attr(name, true) .attr("tg-bind-scope", true) - .addClass("remove-on-close") if attrs elm.attr(attrs) + elm.addClass("remove-on-close") + html = @compile(elm)(scope) $(document.body).append(html) diff --git a/app/modules/services/lightbox-factory.service.spec.coffee b/app/modules/services/lightbox-factory.service.spec.coffee index c939e66b..40d2ccd7 100644 --- a/app/modules/services/lightbox-factory.service.spec.coffee +++ b/app/modules/services/lightbox-factory.service.spec.coffee @@ -56,7 +56,7 @@ describe "tgLightboxFactory", -> lightboxFactoryService.create("fake-directive", attrs) checkAttributes = sinon.match ( (value) -> - return value.attr("class") == "x1" && value.attr("id") == "x2" + return value.hasClass("x1") && value.attr("id") == "x2" && value.hasClass("remove-on-close") ), "checkAttributes" expect(mocks.compile.withArgs(checkAttributes)).to.have.been.calledOnce