From 3851d1fdb40f0c2cf5a718b707097986cd5b1929 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20Espino?= Date: Tue, 21 Mar 2017 17:58:56 +0100 Subject: [PATCH] Now custom color selection flow is coherent --- .../color-selector/color-selector.controller.coffee | 8 +++++--- .../color-selector.controller.spec.coffee | 6 +++--- .../components/color-selector/color-selector.jade | 10 +++++----- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/app/modules/components/color-selector/color-selector.controller.coffee b/app/modules/components/color-selector/color-selector.controller.coffee index 25bd621e..48a1013e 100644 --- a/app/modules/components/color-selector/color-selector.controller.coffee +++ b/app/modules/components/color-selector/color-selector.controller.coffee @@ -40,7 +40,8 @@ class ColorSelectorController @.colorList = _.dropRight(@.colorList) setColor: (color) -> - @.color = @.initColor + @.color = color + @.customColor = color resetColor: () -> if @.isColorRequired and not @.color @@ -48,6 +49,7 @@ class ColorSelectorController toggleColorList: () -> @.displayColorList = !@.displayColorList + @.setColor(@.initColor) @.resetColor() onSelectDropdownColor: (color) -> @@ -57,8 +59,8 @@ class ColorSelectorController onKeyDown: (event) -> if event.which == 13 # ENTER - if @.color or not @.isColorRequired - @.onSelectDropdownColor(@.color) + if @.customColor or not @.isColorRequired + @.onSelectDropdownColor(@.customColor) event.preventDefault() diff --git a/app/modules/components/color-selector/color-selector.controller.spec.coffee b/app/modules/components/color-selector/color-selector.controller.spec.coffee index 5fe727f6..86d08ba8 100644 --- a/app/modules/components/color-selector/color-selector.controller.spec.coffee +++ b/app/modules/components/color-selector/color-selector.controller.spec.coffee @@ -73,11 +73,11 @@ describe "ColorSelector", -> colorSelectorCtrl.onSelectDropdownColor = sinon.stub() event = {which: 13, preventDefault: sinon.stub()} - color = "#fabada" + customColor = "#fabada" - colorSelectorCtrl.color = color + colorSelectorCtrl.customColor = customColor colorSelectorCtrl.onKeyDown(event) expect(event.preventDefault).have.been.called expect(colorSelectorCtrl.onSelectDropdownColor).have.been.called - expect(colorSelectorCtrl.onSelectDropdownColor).have.been.calledWith(color) + expect(colorSelectorCtrl.onSelectDropdownColor).have.been.calledWith(customColor) diff --git a/app/modules/components/color-selector/color-selector.jade b/app/modules/components/color-selector/color-selector.jade index dda5becc..ad0cfdad 100644 --- a/app/modules/components/color-selector/color-selector.jade +++ b/app/modules/components/color-selector/color-selector.jade @@ -26,18 +26,18 @@ ) .custom-color-selector .display-custom-color.empty-color( - ng-if="!vm.color" + ng-if="!vm.customColor" ) .display-custom-color-wrapper .display-custom-color( - ng-if="vm.color" - ng-style="{'background': vm.color}" - ng-click="vm.onSelectDropdownColor(vm.color)" + ng-if="vm.customColor" + ng-style="{'background': vm.customColor}" + ng-click="vm.onSelectDropdownColor(vm.customColor)" ) input.custom-color-input( type="text" maxlength="7" placeholder="Type hex code" - ng-model="vm.color" + ng-model="vm.customColor" ng-keydown="vm.onKeyDown($event)" )