From 3239b8757b438513c42900344e1c7f3f4c094a3c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Xavier=20Juli=C3=A1n?= Date: Tue, 17 Feb 2015 09:35:31 +0100 Subject: [PATCH 1/2] Remove wiki edition ir pre or secondary click --- app/coffee/modules/wiki/main.coffee | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/coffee/modules/wiki/main.coffee b/app/coffee/modules/wiki/main.coffee index 6ef71c78..5b1d75bb 100644 --- a/app/coffee/modules/wiki/main.coffee +++ b/app/coffee/modules/wiki/main.coffee @@ -245,8 +245,9 @@ EditableWikiContentDirective = ($window, $document, $repo, $confirm, $loading, $ # not the currentTarget target = angular.element(event.target) return if not isEditable() - return if target.is('a') + return if target.is('a', '.codehilite', 'pre') return if getSelectedText() + return if event.button == 2 if target.is('pre') prevPos = target.data("scroll-pos") target.data("scroll-pos", null) From c83cc76be82d584b47de34fb4e0ba1a6816af33a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Xavier=20Juli=C3=A1n?= Date: Tue, 17 Feb 2015 14:35:26 +0100 Subject: [PATCH 2/2] Fix bug in chrome caused by a nonsense reason --- app/coffee/modules/wiki/main.coffee | 21 ++++++--------------- app/styles/components/wysiwyg.scss | 7 ++++++- 2 files changed, 12 insertions(+), 16 deletions(-) diff --git a/app/coffee/modules/wiki/main.coffee b/app/coffee/modules/wiki/main.coffee index 5b1d75bb..6a84e194 100644 --- a/app/coffee/modules/wiki/main.coffee +++ b/app/coffee/modules/wiki/main.coffee @@ -235,24 +235,15 @@ EditableWikiContentDirective = ($window, $document, $repo, $confirm, $loading, $ $loading.finish($el.find('.save-container')) $el.on "mousedown", ".view-wiki-content", (event) -> - # Prepare the scroll movement detection - target = angular.element(event.target) - if target.is('pre') - target.data("scroll-pos", target[0].scrollLeft) - - $el.on "mouseup", ".view-wiki-content", (event) -> - # We want to dettect the a inside the div so we use the target and - # not the currentTarget target = angular.element(event.target) return if not isEditable() - return if target.is('a', '.codehilite', 'pre') - return if getSelectedText() return if event.button == 2 - if target.is('pre') - prevPos = target.data("scroll-pos") - target.data("scroll-pos", null) - if prevPos != target[0].scrollLeft - return + + $el.on "mouseup", ".view-wiki-content", (event) -> + target = angular.element(event.target) + return if getSelectedText() + return if target.is('a') + return if target.is('pre') switchToEditMode() diff --git a/app/styles/components/wysiwyg.scss b/app/styles/components/wysiwyg.scss index 45906f7c..5e906637 100644 --- a/app/styles/components/wysiwyg.scss +++ b/app/styles/components/wysiwyg.scss @@ -48,13 +48,18 @@ line-height: 1.4rem; margin-bottom: 1rem; } + .codehilite { + overflow: auto; + } pre, code { @extend %small; - background: $whitish; + background: lighten($grayer, 10%); + color: $whitish; direction: ltr; font-family: 'courier new', 'monospace'; margin-bottom: 1rem; + overflow: auto; unicode-bidi: embed; white-space: pre; }