From 0e35acf9ff5618c9ca9e28cd3ccf4e026d1629e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Garc=C3=ADa?= Date: Mon, 20 Aug 2018 12:55:48 +0200 Subject: [PATCH] Cancel with confirmation in wysiwyg editor --- .../components/detail/header/detail-header.controller.coffee | 4 ++++ app/modules/components/detail/header/detail-header.jade | 2 +- app/modules/components/wysiwyg/wysiwyg.directive.coffee | 4 ++-- app/partials/common/components/wysiwyg-toolbar.jade | 2 +- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/app/modules/components/detail/header/detail-header.controller.coffee b/app/modules/components/detail/header/detail-header.controller.coffee index 11ab7f68..0e88be37 100644 --- a/app/modules/components/detail/header/detail-header.controller.coffee +++ b/app/modules/components/detail/header/detail-header.controller.coffee @@ -58,6 +58,10 @@ class StoryHeaderController canEdit: _.includes(@.project.my_permissions, @.requiredPerm) } + cancelEdit: () -> + @.editMode = false + @.item.subject = @.originalSubject + editSubject: (value) -> selection = @window.getSelection() if selection.type != "Range" diff --git a/app/modules/components/detail/header/detail-header.jade b/app/modules/components/detail/header/detail-header.jade index 40f710cd..2b0d3843 100644 --- a/app/modules/components/detail/header/detail-header.jade +++ b/app/modules/components/detail/header/detail-header.jade @@ -42,7 +42,7 @@ svg-icon="icon-save" ) button.edit-title-button.cancel-title-button.e2e-cancel-title-button( - ng-click="vm.editSubject(false)" + ng-click="vm.cancelEdit(false)" ) tg-svg(svg-icon="icon-close") diff --git a/app/modules/components/wysiwyg/wysiwyg.directive.coffee b/app/modules/components/wysiwyg/wysiwyg.directive.coffee index 4685a954..de8a7f30 100644 --- a/app/modules/components/wysiwyg/wysiwyg.directive.coffee +++ b/app/modules/components/wysiwyg/wysiwyg.directive.coffee @@ -352,7 +352,7 @@ Medium = ($translate, $confirm, $storage, wysiwygService, animationFrame, tgLoad discardLocalStorage = () -> $storage.remove($scope.storageKey) - cancelWithConfirmation = () -> + $scope.cancelWithConfirmation = () -> if $scope.content == $scope.markdown $scope.cancel() @@ -509,7 +509,7 @@ Medium = ($translate, $confirm, $storage, wysiwygService, animationFrame, tgLoad if $scope.editMode && code == 27 e.stopPropagation() - $scope.$applyAsync(cancelWithConfirmation) + $scope.$applyAsync($scope.cancelWithConfirmation) else if code == 27 editorMedium.blur() diff --git a/app/partials/common/components/wysiwyg-toolbar.jade b/app/partials/common/components/wysiwyg-toolbar.jade index 035267a8..b5ee3cc6 100644 --- a/app/partials/common/components/wysiwyg-toolbar.jade +++ b/app/partials/common/components/wysiwyg-toolbar.jade @@ -44,7 +44,7 @@ tg-svg(svg-icon="icon-save") a.e2e-cancel-editor( href="#", - ng-click="cancel($event)" + ng-click="cancelWithConfirmation($event)" title="{{ 'COMMON.CANCEL' | translate }}" ) tg-svg(svg-icon="icon-close")