From ea683056a744ec5ab6758aec4da90d8437da2774 Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Wed, 28 May 2014 18:30:09 +0200 Subject: [PATCH] Remove unnecesary Response usage on wiki page api resource. --- taiga/projects/wiki/api.py | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/taiga/projects/wiki/api.py b/taiga/projects/wiki/api.py index 907b1b15..915d1238 100644 --- a/taiga/projects/wiki/api.py +++ b/taiga/projects/wiki/api.py @@ -15,6 +15,8 @@ # along with this program. If not, see . from django.utils.translation import ugettext_lazy as _ +from django.shortcuts import get_object_or_404 + from rest_framework.permissions import IsAuthenticated from rest_framework.response import Response from rest_framework import status @@ -50,17 +52,13 @@ class WikiViewSet(NotificationSenderMixin, ModelCrudViewSet): project_id = request.DATA.get("project_id", None) if not content: - return Response({"content": "No content parameter"}, status=status.HTTP_400_BAD_REQUEST) + raise exc.WrongArguments({"content": "No content parameter"}) + if not project_id: - return Response({"project_id": "No project_id parameter"}, status=status.HTTP_400_BAD_REQUEST) - - try: - project = Project.objects.get(pk=project_id) - except Project.DoesNotExist: - return Response({"project_id": "Not valid project id"}, status=status.HTTP_400_BAD_REQUEST) + raise exc.WrongArguments({"project_id": "No project_id parameter"}) + project = get_object_or_404(Project, pk=project_id) data = mdrender(project, content) - return Response({"data": data}) def pre_conditions_on_save(self, obj):