taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

simplified how the get_total_points is calculated

remotes/origin/issue/4795/notification_even_they_are_disabled
Allan Simon 2016-10-10 05:58:49 +08:00 committed by David Barragán Merino
parent a165947179
commit ea0f496c9b
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
taiga/projects/userstories/models.py
View File

@ -137,14 +137,14 @@ class UserStory(OCCModelMixin, WatchedModelMixin, BlockedMixin, TaggedMixin, mod
return self.role_points return self.role_points
def get_total_points(self): def get_total_points(self):
not_null_role_points = [rp for rp in self.role_points.all() if rp.points.value is not None] not_null_role_points = [
rp.points.value
for rp in self.role_points.all()
if rp.points.value is not None
]
#If we only have None values the sum should be None #If we only have None values the sum should be None
if not not_null_role_points: if not not_null_role_points:
return None return None
total = 0.0 return sum(not_null_role_points)
for rp in not_null_role_points:
total += rp.points.value
return total