taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Refactoring epics API

remotes/origin/issue/4795/notification_even_they_are_disabled
Alejandro Alonso 2016-08-04 14:33:28 +02:00 committed by David Barragán Merino
parent 32267af4f4
commit e83e4b8beb
3 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
taiga/projects/epics/api.py
View File

@ -232,6 +232,7 @@ class EpicRelatedUserStoryViewSet(NestedViewSetMixin, BlockedByProjectMixin, Mod
validator_class = validators.EpicRelatedUserStoryValidator validator_class = validators.EpicRelatedUserStoryValidator
model = models.RelatedUserStory model = models.RelatedUserStory
permission_classes = (permissions.EpicRelatedUserStoryPermission,) permission_classes = (permissions.EpicRelatedUserStoryPermission,)
lookup_field = "user_story_id"
""" """
Updating the order attribute can affect the ordering of another userstories in the epic Updating the order attribute can affect the ordering of another userstories in the epic

4
taiga/projects/epics/models.py
View File

@ -106,3 +106,7 @@ class RelatedUserStory(models.Model):
def __str__(self): def __str__(self):
return "{0} - {1}".format(self.epic_id, self.user_story_id) return "{0} - {1}".format(self.epic_id, self.user_story_id)
@property
def project(self):
return self.epic.project

16
tests/integration/test_epics.py
View File

@ -136,10 +136,10 @@ def test_set_related_userstory_existing(client):
f.MembershipFactory.create(project=epic.project, user=user, is_admin=True) f.MembershipFactory.create(project=epic.project, user=user, is_admin=True)
f.MembershipFactory.create(project=us.project, user=user, is_admin=True) f.MembershipFactory.create(project=us.project, user=user, is_admin=True)
url = reverse('epics-set-related-userstory', kwargs={"pk": epic.pk}) url = reverse('epics-related-userstories-list', args=[epic.pk])
data = { data = {
"us_id": us.id, "user_story": us.id,
"order": 77 "order": 77
} }
client.login(user) client.login(user)
@ -158,15 +158,9 @@ def test_unset_related_userstory(client):
related_us = f.RelatedUserStory.create(epic=epic, user_story=us, order=55) related_us = f.RelatedUserStory.create(epic=epic, user_story=us, order=55)
f.MembershipFactory.create(project=epic.project, user=user, is_admin=True) f.MembershipFactory.create(project=epic.project, user=user, is_admin=True)
url = reverse('epics-unset-related-userstory', kwargs={"pk": epic.pk}) url = reverse('epics-related-userstories-detail', args=[epic.pk, us.pk])
data = {
"us_id": us.id
}
client.login(user) client.login(user)
response = client.json.post(url, json.dumps(data)) response = client.delete(url)
print(response.data) assert response.status_code == 204
assert response.status_code == 200
assert response.data['user_stories_counts'] == {'opened': 0, 'closed': 0}
assert not models.RelatedUserStory.objects.filter(id=related_us.id).exists() assert not models.RelatedUserStory.objects.filter(id=related_us.id).exists()