taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Issue #1734: currentPassword is not needed for github users

remotes/origin/enhancement/email-actions
David Barragán Merino 2015-01-13 14:25:01 +01:00 committed by Jesús Espino
parent 64dde7870d
commit e81a73e24b
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
taiga/users/api.py
View File

@ -142,7 +142,10 @@ class UsersViewSet(ModelCrudViewSet):
current_password = request.DATA.get("current_password") current_password = request.DATA.get("current_password")
password = request.DATA.get("password") password = request.DATA.get("password")
if not current_password:
# NOTE: GitHub users have no password yet (request.user.passwor == '') so
# current_password can be None
if not current_password and request.user.password:
raise exc.WrongArguments(_("Current password parameter needed")) raise exc.WrongArguments(_("Current password parameter needed"))
if not password: if not password:
@ -151,7 +154,7 @@ class UsersViewSet(ModelCrudViewSet):
if len(password) < 6: if len(password) < 6:
raise exc.WrongArguments(_("Invalid password length at least 6 charaters needed")) raise exc.WrongArguments(_("Invalid password length at least 6 charaters needed"))
if not request.user.check_password(current_password): if current_password and not request.user.check_password(current_password):
raise exc.WrongArguments(_("Invalid current password")) raise exc.WrongArguments(_("Invalid current password"))
request.user.set_password(password) request.user.set_password(password)