taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Adding test for create of membership

remotes/origin/enhancement/email-actions
Jesús Espino 2014-07-31 10:45:50 +02:00
parent 5cd3a717d4
commit e55acc11c2
3 changed files with 42 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
taiga/projects/api.py
View File

@ -153,9 +153,14 @@ class MembershipViewSet(ModelCrudViewSet):
serializer = self.get_serializer(data=data, files=request.FILES) serializer = self.get_serializer(data=data, files=request.FILES)
if serializer.is_valid(): if serializer.is_valid():
qs = self.model.objects.filter(Q(project_id=serializer.data["project"], project_id = serializer.data["project"]
project = get_object_or_404(models.Project, id=project_id)
self.check_permissions(request, 'create', project)
qs = self.model.objects.filter(Q(project_id=project_id,
user__email=serializer.data["email"]) | user__email=serializer.data["email"]) |
Q(project_id=serializer.data["project"], Q(project_id=project_id,
email=serializer.data["email"])) email=serializer.data["email"]))
if qs.count() > 0: if qs.count() > 0:
raise exc.WrongArguments(_("Email address is already taken.")) raise exc.WrongArguments(_("Email address is already taken."))

6
taiga/projects/serializers.py
View File

@ -87,9 +87,9 @@ class IssueTypeSerializer(serializers.ModelSerializer):
# Projects # Projects
class MembershipSerializer(serializers.ModelSerializer): class MembershipSerializer(serializers.ModelSerializer):
role_name = serializers.CharField(source='role.name', required=False) role_name = serializers.CharField(source='role.name', required=False, read_only=True)
full_name = serializers.CharField(source='user.get_full_name', required=False) full_name = serializers.CharField(source='user.get_full_name', required=False, read_only=True)
color = serializers.CharField(source='user.color', required=False) color = serializers.CharField(source='user.color', required=False, read_only=True)
photo = serializers.SerializerMethodField("get_photo") photo = serializers.SerializerMethodField("get_photo")
invited_by = serializers.SerializerMethodField("get_invited_by") invited_by = serializers.SerializerMethodField("get_invited_by")
project_name = serializers.SerializerMethodField("get_project_name") project_name = serializers.SerializerMethodField("get_project_name")

32
tests/integration/resources_permissions/test_projects_choices_resources.py
View File

@ -1473,6 +1473,38 @@ def test_membership_patch(client, data):
results = helper_test_http_method(client, 'patch', private2_url, '{"name": "Test"}', users) results = helper_test_http_method(client, 'patch', private2_url, '{"name": "Test"}', users)
assert results == [401, 403, 403, 403, 200] assert results == [401, 403, 403, 403, 200]
def test_membership_create(client, data):
url = reverse('memberships-list')
users = [
None,
data.registered_user,
data.project_member_without_perms,
data.project_member_with_perms,
data.project_owner
]
membership_data = serializers.MembershipSerializer(data.public_membership).data
membership_data["id"] = None
membership_data["email"] = "test1@test.com"
membership_data = JSONRenderer().render(membership_data)
results = helper_test_http_method(client, 'post', url, membership_data, users)
assert results == [401, 403, 403, 403, 201]
membership_data = serializers.MembershipSerializer(data.private_membership1).data
membership_data["id"] = None
membership_data["email"] = "test2@test.com"
membership_data = JSONRenderer().render(membership_data)
results = helper_test_http_method(client, 'post', url, membership_data, users)
assert results == [401, 403, 403, 403, 201]
membership_data = serializers.MembershipSerializer(data.private_membership2).data
membership_data["id"] = None
membership_data["email"] = "test3@test.com"
membership_data = JSONRenderer().render(membership_data)
results = helper_test_http_method(client, 'post', url, membership_data, users)
assert results == [401, 403, 403, 403, 201]
def test_project_template_retrieve(client, data): def test_project_template_retrieve(client, data):
url = reverse('project-templates-detail', kwargs={"pk": data.project_template.pk}) url = reverse('project-templates-detail', kwargs={"pk": data.project_template.pk})