From 139d22ff0376aa196ba7a329944034e8eba53c03 Mon Sep 17 00:00:00 2001 From: Alejandro Alonso Date: Tue, 4 Aug 2015 13:02:17 +0200 Subject: [PATCH] Issue #3117 - [Dev] After add task in bulk to a closed US, it is not reopened --- taiga/projects/tasks/apps.py | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/taiga/projects/tasks/apps.py b/taiga/projects/tasks/apps.py index 445ca63b..8d9a112d 100644 --- a/taiga/projects/tasks/apps.py +++ b/taiga/projects/tasks/apps.py @@ -23,19 +23,6 @@ from taiga.projects.custom_attributes import signals as custom_attributes_handle from . import signals as handlers def connect_tasks_signals(): - # Cached prev object version - signals.pre_save.connect(handlers.cached_prev_task, - sender=apps.get_model("tasks", "Task"), - dispatch_uid="cached_prev_task") - - # Open/Close US and Milestone - signals.post_save.connect(handlers.try_to_close_or_open_us_and_milestone_when_create_or_edit_task, - sender=apps.get_model("tasks", "Task"), - dispatch_uid="try_to_close_or_open_us_and_milestone_when_create_or_edit_task") - signals.post_delete.connect(handlers.try_to_close_or_open_us_and_milestone_when_delete_task, - sender=apps.get_model("tasks", "Task"), - dispatch_uid="try_to_close_or_open_us_and_milestone_when_delete_task") - # Tags signals.pre_save.connect(generic_handlers.tags_normalization, sender=apps.get_model("tasks", "Task"), @@ -47,6 +34,18 @@ def connect_tasks_signals(): sender=apps.get_model("tasks", "Task"), dispatch_uid="update_project_tags_when_delete_tagglabe_item_task") +def connect_tasks_close_or_open_us_and_milestone_signals(): + # Cached prev object version + signals.pre_save.connect(handlers.cached_prev_task, + sender=apps.get_model("tasks", "Task"), + dispatch_uid="cached_prev_task") + # Open/Close US and Milestone + signals.post_save.connect(handlers.try_to_close_or_open_us_and_milestone_when_create_or_edit_task, + sender=apps.get_model("tasks", "Task"), + dispatch_uid="try_to_close_or_open_us_and_milestone_when_create_or_edit_task") + signals.post_delete.connect(handlers.try_to_close_or_open_us_and_milestone_when_delete_task, + sender=apps.get_model("tasks", "Task"), + dispatch_uid="try_to_close_or_open_us_and_milestone_when_delete_task") def connect_tasks_custom_attributes_signals(): signals.post_save.connect(custom_attributes_handlers.create_custom_attribute_value_when_create_task, @@ -56,24 +55,29 @@ def connect_tasks_custom_attributes_signals(): def connect_all_tasks_signals(): connect_tasks_signals() + connect_tasks_close_or_open_us_and_milestone_signals() connect_tasks_custom_attributes_signals() def disconnect_tasks_signals(): - signals.pre_save.disconnect(sender=apps.get_model("tasks", "Task"), dispatch_uid="cached_prev_task") - signals.post_save.disconnect(sender=apps.get_model("tasks", "Task"), dispatch_uid="try_to_close_or_open_us_and_milestone_when_create_or_edit_task") - signals.post_delete.disconnect(sender=apps.get_model("tasks", "Task"), dispatch_uid="try_to_close_or_open_us_and_milestone_when_delete_task") signals.pre_save.disconnect(sender=apps.get_model("tasks", "Task"), dispatch_uid="tags_normalization") signals.post_save.disconnect(sender=apps.get_model("tasks", "Task"), dispatch_uid="update_project_tags_when_create_or_edit_tagglabe_item") signals.post_delete.disconnect(sender=apps.get_model("tasks", "Task"), dispatch_uid="update_project_tags_when_delete_tagglabe_item") +def disconnect_tasks_close_or_open_us_and_milestone_signals(): + signals.pre_save.disconnect(sender=apps.get_model("tasks", "Task"), dispatch_uid="cached_prev_task") + signals.post_save.disconnect(sender=apps.get_model("tasks", "Task"), dispatch_uid="try_to_close_or_open_us_and_milestone_when_create_or_edit_task") + signals.post_delete.disconnect(sender=apps.get_model("tasks", "Task"), dispatch_uid="try_to_close_or_open_us_and_milestone_when_delete_task") + + def disconnect_tasks_custom_attributes_signals(): signals.post_save.disconnect(sender=apps.get_model("tasks", "Task"), dispatch_uid="create_custom_attribute_value_when_create_task") def disconnect_all_tasks_signals(): disconnect_tasks_signals() + disconnect_tasks_close_or_open_us_and_milestone_signals() disconnect_tasks_custom_attributes_signals()