taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[Backport] Fix trello importer error where avatarHash is a NoneType object

remotes/origin/live-notifications
David Barragán Merino 2017-03-13 11:40:06 +01:00
parent b57973767b
commit 8d7fd290e2
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
taiga/importers/trello/importer.py
View File

@ -129,10 +129,20 @@ class TrelloImporter:
for member in self._client.get("/board/{}/members/all".format(project_id), {"fields": "id"}): for member in self._client.get("/board/{}/members/all".format(project_id), {"fields": "id"}):
user = self._client.get("/member/{}".format(member['id']), {"fields": "id,fullName,email,avatarSource,avatarHash,gravatarHash"}) user = self._client.get("/member/{}".format(member['id']), {"fields": "id,fullName,email,avatarSource,avatarHash,gravatarHash"})
avatar = None avatar = None
if user['avatarSource'] == "gravatar" and user['gravatarHash']: try:
avatar = 'https://www.gravatar.com/avatar/' + user['gravatarHash'] + '.jpg?s=50' if user['avatarSource'] == "gravatar" and user['gravatarHash']:
elif user['avatarHash']: avatar = 'https://www.gravatar.com/avatar/' + user['gravatarHash'] + '.jpg?s=50'
avatar = 'https://trello-avatars.s3.amazonaws.com/' + user['avatarHash'] + '/50.png' elif user['avatarHash'] is not None:
avatar = 'https://trello-avatars.s3.amazonaws.com/' + user['avatarHash'] + '/50.png'
except:
# NOTE: Sometimes this piece of code return this exception:
#
# File "/home/taiga/taiga-back/taiga/importers/trello/importer.py" in list_users
# 135. avatar = 'https://trello-avatars.s3.amazonaws.com/' + user['avatarHash'] + '/50.png'
#
# Exception Type: TypeError at /api/v1/importers/trello/list_users
# Exception Value: Can't convert 'NoneType' object to str implicitly
pass
members.append({ members.append({
"id": user['id'], "id": user['id'],