taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[Backport] Importing valid project without slug

remotes/origin/issue/4795/notification_even_they_are_disabled
Alejandro Alonso 2016-02-09 12:41:29 +01:00 committed by David Barragán Merino
parent 91697207cb
commit 8d2a4afe2a
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
taiga/export_import/api.py
View File

@ -205,7 +205,8 @@ class ProjectImporterViewSet(mixins.ImportThrottlingPolicyMixin, CreateModelMixi
except Exception: except Exception:
raise exc.WrongArguments(_("Invalid dump format")) raise exc.WrongArguments(_("Invalid dump format"))
if Project.objects.filter(slug=dump['slug']).exists(): slug = dump.get('slug', None)
if slug is not None and Project.objects.filter(slug=slug).exists():
del dump['slug'] del dump['slug']
if settings.CELERY_ENABLED: if settings.CELERY_ENABLED:

18
tests/integration/test_importer_api.py
View File

@ -1059,3 +1059,21 @@ def test_dump_import_throttling(client, settings):
assert response.status_code == 201 assert response.status_code == 201
response = client.post(url, {'dump': data}) response = client.post(url, {'dump': data})
assert response.status_code == 429 assert response.status_code == 429
def test_valid_dump_import_without_slug(client):
project = f.ProjectFactory.create(slug="existing-slug")
user = f.UserFactory.create()
client.login(user)
url = reverse("importer-load-dump")
data = ContentFile(bytes(json.dumps({
"name": "Project name",
"description": "Valid project desc",
"is_private": True
}), "utf-8"))
data.name = "test"
response = client.post(url, {'dump': data})
assert response.status_code == 201