taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #612 from taigaio/filtering-watchers-value-errors 

Detecting invalid values when filtering by watchers
remotes/origin/issue/4795/notification_even_they_are_disabled
David Barragán Merino 2016-02-10 20:31:14 +01:00
parent b5d20ca043 02013f6222
commit 800d4d398a
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
taiga/base/filters.py
View File

@ -435,8 +435,12 @@ class WatchersFilter(FilterBackend):
if query_watchers: if query_watchers:
WatchedModel = apps.get_model("notifications", "Watched") WatchedModel = apps.get_model("notifications", "Watched")
watched_type = ContentType.objects.get_for_model(queryset.model) watched_type = ContentType.objects.get_for_model(queryset.model)
try:
watched_ids = WatchedModel.objects.filter(content_type=watched_type, user__id__in=query_watchers).values_list("object_id", flat=True) watched_ids = WatchedModel.objects.filter(content_type=watched_type, user__id__in=query_watchers).values_list("object_id", flat=True)
queryset = queryset.filter(id__in=watched_ids) queryset = queryset.filter(id__in=watched_ids)
except ValueError:
raise exc.BadRequest(_("Error in filter params types."))
return super().filter_queryset(request, queryset, view) return super().filter_queryset(request, queryset, view)