taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixing error on task update

remotes/origin/issue/4795/notification_even_they_are_disabled
Alejandro Alonso 2016-11-15 11:31:41 +01:00
parent 12e6e8e810
commit 78510cd676
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
taiga/projects/tasks/api.py
View File

@ -258,7 +258,6 @@ class TaskViewSet(OCCResourceMixin, VotedResourceMixin, HistoryResourceMixin, Wa
return response.Ok(tasks_serialized.data) return response.Ok(tasks_serialized.data)
def _bulk_update_order(self, order_field, request, **kwargs): def _bulk_update_order(self, order_field, request, **kwargs):
validator = validators.UpdateTasksOrderBulkValidator(data=request.DATA) validator = validators.UpdateTasksOrderBulkValidator(data=request.DATA)
if not validator.is_valid(): if not validator.is_valid():

2
taiga/projects/tasks/signals.py
View File

@ -39,6 +39,7 @@ def try_to_close_or_open_us_and_milestone_when_create_or_edit_task(sender, insta
_try_to_close_or_open_us_when_create_or_edit_task(instance) _try_to_close_or_open_us_when_create_or_edit_task(instance)
_try_to_close_or_open_milestone_when_create_or_edit_task(instance) _try_to_close_or_open_milestone_when_create_or_edit_task(instance)
def try_to_close_or_open_us_and_milestone_when_delete_task(sender, instance, **kwargs): def try_to_close_or_open_us_and_milestone_when_delete_task(sender, instance, **kwargs):
_try_to_close_or_open_us_when_delete_task(instance) _try_to_close_or_open_us_when_delete_task(instance)
_try_to_close_milestone_when_delete_task(instance) _try_to_close_milestone_when_delete_task(instance)
@ -96,6 +97,7 @@ def _try_to_close_milestone_when_delete_task(instance):
if instance.milestone_id and services.calculate_milestone_is_closed(instance.milestone): if instance.milestone_id and services.calculate_milestone_is_closed(instance.milestone):
services.close_milestone(instance.milestone) services.close_milestone(instance.milestone)
#################################### ####################################
# Signals for set finished date # Signals for set finished date
#################################### ####################################

5
taiga/projects/userstories/signals.py
View File

@ -59,8 +59,9 @@ def update_role_points_when_create_or_edit_us(sender, instance, **kwargs):
def update_milestone_of_tasks_when_edit_us(sender, instance, created, **kwargs): def update_milestone_of_tasks_when_edit_us(sender, instance, created, **kwargs):
if not created: if not created:
instance.tasks.exclude(milestone=instance.milestone).update(milestone=instance.milestone) tasks = instance.tasks.exclude(milestone=instance.milestone)
for task in instance.tasks.all(): tasks.update(milestone=instance.milestone)
for task in tasks:
take_snapshot(task) take_snapshot(task)