taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Small refactor about ignored fields on HistoryEntries

remotes/origin/logger
Alejandro Alonso 2015-09-30 13:01:43 +02:00
parent 73c148f0fb
commit 630ea08821
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
taiga/projects/history/models.py
View File

@ -29,6 +29,9 @@ from .choices import HISTORY_TYPE_CHOICES
from taiga.base.utils.diff import make_diff as make_diff_from_dicts from taiga.base.utils.diff import make_diff as make_diff_from_dicts
# This keys has been removed from freeze_impl so we can have objects where the
# previous diff has value for the attribute and we want to prevent their propagation
IGNORE_DIFF_FIELDS = [ "watchers", "description_diff", "content_diff", "blocked_note_diff"]
def _generate_uuid(): def _generate_uuid():
return str(uuid.uuid1()) return str(uuid.uuid1())
@ -127,22 +130,12 @@ class HistoryEntry(models.Model):
for key in self.diff: for key in self.diff:
value = None value = None
if key in IGNORE_DIFF_FIELDS:
# Note: Hack to prevent description_diff propagation
# on old HistoryEntry objects.
if key == "description_diff":
continue
elif key == "content_diff":
continue
elif key == "blocked_note_diff":
continue continue
elif key in["description", "content", "blocked_note"]: elif key in["description", "content", "blocked_note"]:
(key, value) = resolve_diff_value(key) (key, value) = resolve_diff_value(key)
elif key in users_keys: elif key in users_keys:
value = [resolve_value("users", x) for x in self.diff[key]] value = [resolve_value("users", x) for x in self.diff[key]]
elif key == "watchers":
# Old instances can have watchers
continue
elif key == "points": elif key == "points":
points = {} points = {}