From 61141c321ec74f8ba4ef4ba21b251982d0e5c2d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Barrag=C3=A1n=20Merino?= Date: Thu, 6 Nov 2014 19:36:26 +0100 Subject: [PATCH] Fix connectors_github tests --- tests/unit/test_connectors_github.py | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/tests/unit/test_connectors_github.py b/tests/unit/test_connectors_github.py index 48c7355c..f27a2f8a 100644 --- a/tests/unit/test_connectors_github.py +++ b/tests/unit/test_connectors_github.py @@ -33,8 +33,24 @@ def test_url_builder(): "https://api.github.com/user/emails") +def test_login_without_settings_params(): + with pytest.raises(exc.GitHubApiError) as e, \ + patch("taiga.base.connectors.github.requests") as m_requests: + m_requests.post.return_value = m_response = Mock() + m_response.status_code = 200 + m_response.json.return_value = {"access_token": "xxxxxxxx"} + + auth_info = github.login("*access-code*", "**client-id**", "*ient-secret*", github.HEADERS) + assert e.value.status_code == 400 + assert "error_message" in e.value.detail + + def test_login_success(): - with patch("taiga.base.connectors.github.requests") as m_requests: + with patch("taiga.base.connectors.github.requests") as m_requests, \ + patch("taiga.base.connectors.github.CLIENT_ID") as CLIENT_ID, \ + patch("taiga.base.connectors.github.CLIENT_SECRET") as CLIENT_SECRET: + CLIENT_ID = "*CLIENT_ID*" + CLIENT_SECRET = "*CLIENT_SECRET*" m_requests.post.return_value = m_response = Mock() m_response.status_code = 200 m_response.json.return_value = {"access_token": "xxxxxxxx"} @@ -52,7 +68,11 @@ def test_login_success(): def test_login_whit_errors(): with pytest.raises(exc.GitHubApiError) as e, \ - patch("taiga.base.connectors.github.requests") as m_requests: + patch("taiga.base.connectors.github.requests") as m_requests, \ + patch("taiga.base.connectors.github.CLIENT_ID") as CLIENT_ID, \ + patch("taiga.base.connectors.github.CLIENT_SECRET") as CLIENT_SECRET: + CLIENT_ID = "*CLIENT_ID*" + CLIENT_SECRET = "*CLIENT_SECRET*" m_requests.post.return_value = m_response = Mock() m_response.status_code = 200 m_response.json.return_value = {"error": "Invalid credentials"}