taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #143 from taigaio/refactor/remove-projects-tags-call 

Remove api/v1/projects/XX/tags call (Not necessary)
remotes/origin/enhancement/email-actions
Alejandro 2014-10-30 18:09:48 +01:00
parent cd890330ed 77d03c000f
commit 5ac3bf15ab
2 changed files with 14 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
taiga/projects/api.py
View File

@ -66,20 +66,6 @@ class ProjectViewSet(ModelCrudViewSet):
self.check_permissions(request, 'stats', project) self.check_permissions(request, 'stats', project)
return Response(services.get_stats_for_project(project)) return Response(services.get_stats_for_project(project))
@detail_route(methods=['post'])
def star(self, request, pk=None):
project = self.get_object()
self.check_permissions(request, 'star', project)
votes_service.add_vote(project, user=request.user)
return Response(status=status.HTTP_200_OK)
@detail_route(methods=['post'])
def unstar(self, request, pk=None):
project = self.get_object()
self.check_permissions(request, 'unstar', project)
votes_service.remove_vote(project, user=request.user)
return Response(status=status.HTTP_200_OK)
@detail_route(methods=['get']) @detail_route(methods=['get'])
def issues_stats(self, request, pk=None): def issues_stats(self, request, pk=None):
project = self.get_object() project = self.get_object()
@ -92,18 +78,26 @@ class ProjectViewSet(ModelCrudViewSet):
self.check_permissions(request, 'issues_filters_data', project) self.check_permissions(request, 'issues_filters_data', project)
return Response(services.get_issues_filters_data(project)) return Response(services.get_issues_filters_data(project))
@detail_route(methods=['get'])
def tags(self, request, pk=None):
project = self.get_object()
self.check_permissions(request, 'tags', project)
return Response(services.get_all_tags(project))
@detail_route(methods=['get']) @detail_route(methods=['get'])
def tags_colors(self, request, pk=None): def tags_colors(self, request, pk=None):
project = self.get_object() project = self.get_object()
self.check_permissions(request, 'tags_colors', project) self.check_permissions(request, 'tags_colors', project)
return Response(dict(project.tags_colors)) return Response(dict(project.tags_colors))
@detail_route(methods=['post'])
def star(self, request, pk=None):
project = self.get_object()
self.check_permissions(request, 'star', project)
votes_service.add_vote(project, user=request.user)
return Response(status=status.HTTP_200_OK)
@detail_route(methods=['post'])
def unstar(self, request, pk=None):
project = self.get_object()
self.check_permissions(request, 'unstar', project)
votes_service.remove_vote(project, user=request.user)
return Response(status=status.HTTP_200_OK)
@detail_route(methods=['get']) @detail_route(methods=['get'])
def fans(self, request, pk=None): def fans(self, request, pk=None):
project = self.get_object() project = self.get_object()

19
tests/integration/resources_permissions/test_projects_resource.py
View File

@ -262,25 +262,6 @@ def test_project_action_issues_filters_data(client, data):
assert results == [404, 404, 200, 200] assert results == [404, 404, 200, 200]
def test_project_action_tags(client, data):
public_url = reverse('projects-tags', kwargs={"pk": data.public_project.pk})
private1_url = reverse('projects-tags', kwargs={"pk": data.private_project1.pk})
private2_url = reverse('projects-tags', kwargs={"pk": data.private_project2.pk})
users = [
None,
data.registered_user,
data.project_member_with_perms,
data.project_owner
]
results = helper_test_http_method(client, 'get', public_url, None, users)
assert results == [200, 200, 200, 200]
results = helper_test_http_method(client, 'get', private1_url, None, users)
assert results == [200, 200, 200, 200]
results = helper_test_http_method(client, 'get', private2_url, None, users)
assert results == [404, 404, 200, 200]
def test_project_action_fans(client, data): def test_project_action_fans(client, data):
public_url = reverse('projects-fans', kwargs={"pk": data.public_project.pk}) public_url = reverse('projects-fans', kwargs={"pk": data.public_project.pk})
private1_url = reverse('projects-fans', kwargs={"pk": data.private_project1.pk}) private1_url = reverse('projects-fans', kwargs={"pk": data.private_project1.pk})