taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Migrating references validators

remotes/origin/issue/4795/notification_even_they_are_disabled
Jesús Espino 2016-07-05 21:22:49 +02:00
parent a51ca8c85a
commit 4f5a4f1314
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
taiga/projects/references/api.py
View File

@ -24,7 +24,7 @@ from taiga.base.api import viewsets
from taiga.base.api.utils import get_object_or_404 from taiga.base.api.utils import get_object_or_404
from taiga.permissions.services import user_has_perm from taiga.permissions.services import user_has_perm
from .serializers import ResolverSerializer from .validators import ResolverValidator
from . import permissions from . import permissions
@ -32,11 +32,11 @@ class ResolverViewSet(viewsets.ViewSet):
permission_classes = (permissions.ResolverPermission,) permission_classes = (permissions.ResolverPermission,)
def list(self, request, **kwargs): def list(self, request, **kwargs):
serializer = ResolverSerializer(data=request.QUERY_PARAMS) validator = ResolverValidator(data=request.QUERY_PARAMS)
if not serializer.is_valid(): if not validator.is_valid():
raise exc.BadRequest(serializer.errors) raise exc.BadRequest(validator.errors)
data = serializer.data data = validator.data
project_model = apps.get_model("projects", "Project") project_model = apps.get_model("projects", "Project")
project = get_object_or_404(project_model, slug=data["project"]) project = get_object_or_404(project_model, slug=data["project"])

3
taiga/projects/references/serializers.py → taiga/projects/references/validators.py
View File

@ -17,9 +17,10 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
from taiga.base.api import serializers from taiga.base.api import serializers
from taiga.base.api import validators
class ResolverSerializer(serializers.Serializer): class ResolverValidator(validators.Validator):
project = serializers.CharField(max_length=512, required=True) project = serializers.CharField(max_length=512, required=True)
milestone = serializers.CharField(max_length=512, required=False) milestone = serializers.CharField(max_length=512, required=False)
us = serializers.IntegerField(required=False) us = serializers.IntegerField(required=False)