From 4620e1402878b365e87b9d1330aa86c2c7b5d2aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Barrag=C3=A1n=20Merino?= Date: Thu, 3 Oct 2013 19:36:45 +0200 Subject: [PATCH] Fixed a problems with the get_history method --- greenmine/projects/issues/serializers.py | 11 ++++++----- greenmine/projects/tasks/serializers.py | 11 ++++++----- greenmine/projects/userstories/serializers.py | 11 ++++++----- 3 files changed, 18 insertions(+), 15 deletions(-) diff --git a/greenmine/projects/issues/serializers.py b/greenmine/projects/issues/serializers.py index d8e35957..1a6b2b50 100644 --- a/greenmine/projects/issues/serializers.py +++ b/greenmine/projects/issues/serializers.py @@ -70,11 +70,12 @@ class IssueSerializer(serializers.ModelSerializer): diff_list = [] current = None - for version in reversed(list(reversion.get_for_object(obj))): - if current: - issues_diff = self.get_issues_diff(current, version) - diff_list.append(issues_diff) + if obj: + for version in reversed(list(reversion.get_for_object(obj))): + if current: + issues_diff = self.get_issues_diff(current, version) + diff_list.append(issues_diff) - current = version + current = version return diff_list diff --git a/greenmine/projects/tasks/serializers.py b/greenmine/projects/tasks/serializers.py index ab9f02b2..5803f921 100644 --- a/greenmine/projects/tasks/serializers.py +++ b/greenmine/projects/tasks/serializers.py @@ -53,11 +53,12 @@ class TaskSerializer(serializers.ModelSerializer): diff_list = [] current = None - for version in reversed(list(reversion.get_for_object(obj))): - if current: - task_diff = self.get_task_diff(current, version) - diff_list.append(task_diff) + if obj: + for version in reversed(list(reversion.get_for_object(obj))): + if current: + task_diff = self.get_task_diff(current, version) + diff_list.append(task_diff) - current = version + current = version return diff_list diff --git a/greenmine/projects/userstories/serializers.py b/greenmine/projects/userstories/serializers.py index 553bff22..70213296 100644 --- a/greenmine/projects/userstories/serializers.py +++ b/greenmine/projects/userstories/serializers.py @@ -84,11 +84,12 @@ class UserStorySerializer(serializers.ModelSerializer): diff_list = [] current = None - for version in reversed(list(reversion.get_for_object(obj))): - if current: - us_diff = self.get_user_stories_diff(current, version) - diff_list.append(us_diff) + if obj: + for version in reversed(list(reversion.get_for_object(obj))): + if current: + us_diff = self.get_user_stories_diff(current, version) + diff_list.append(us_diff) - current = version + current = version return diff_list