From d8b8c1655bd28acb6e3ade75cdbac0c0af752692 Mon Sep 17 00:00:00 2001 From: Miguel Gonzalez Date: Wed, 14 Mar 2018 13:26:01 +0100 Subject: [PATCH 1/2] Remove wrong check about status Do not validate is target status is the current one. --- taiga/projects/userstories/validators.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/taiga/projects/userstories/validators.py b/taiga/projects/userstories/validators.py index 0ebdcc4b..7388782b 100644 --- a/taiga/projects/userstories/validators.py +++ b/taiga/projects/userstories/validators.py @@ -125,8 +125,6 @@ class UpdateUserStoriesOrderBulkValidator(ProjectExistsValidator, validators.Val def validate_bulk_stories(self, attrs, source): filters = {"project__id": attrs["project_id"]} - if "status_id" in attrs: - filters["status__id"] = attrs["status_id"] if "milestone_id" in attrs: filters["milestone__id"] = attrs["milestone_id"] From 04440446464f2a8d6cf5938ec702c47078cec0c3 Mon Sep 17 00:00:00 2001 From: Miguel Gonzalez Date: Thu, 15 Mar 2018 09:46:03 +0100 Subject: [PATCH 2/2] Fix test (2/) --- tests/integration/test_userstories.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/integration/test_userstories.py b/tests/integration/test_userstories.py index 37c2682d..f622971c 100644 --- a/tests/integration/test_userstories.py +++ b/tests/integration/test_userstories.py @@ -264,17 +264,14 @@ def test_api_update_orders_in_bulk_invalid_status(client): response = client.json.post(url1, json.dumps(data)) assert response.status_code == 400, response.data assert "status_id" in response.data - assert "bulk_stories" in response.data response = client.json.post(url2, json.dumps(data)) assert response.status_code == 400, response.data assert "status_id" in response.data - assert "bulk_stories" in response.data response = client.json.post(url3, json.dumps(data)) assert response.status_code == 400, response.data assert "status_id" in response.data - assert "bulk_stories" in response.data def test_api_update_orders_in_bulk_invalid_milestione(client):