taiga
/
taiga-back
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixing milestone serializer, adding duplicated name validation

remotes/origin/enhancement/email-actions
Alejandro Alonso 2014-06-26 16:58:48 +02:00
parent e2b8687980
commit 19a8dc14c8
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
taiga/projects/milestones/serializers.py
View File

@ -25,10 +25,10 @@ from . import models
class MilestoneSerializer(serializers.ModelSerializer): class MilestoneSerializer(serializers.ModelSerializer):
user_stories = UserStorySerializer(many=True, required=False) user_stories = UserStorySerializer(many=True, required=False)
total_points = serializers.SerializerMethodField('get_total_points') total_points = serializers.SerializerMethodField("get_total_points")
closed_points = serializers.SerializerMethodField('get_closed_points') closed_points = serializers.SerializerMethodField("get_closed_points")
client_increment_points = serializers.SerializerMethodField('get_client_increment_points') client_increment_points = serializers.SerializerMethodField("get_client_increment_points")
team_increment_points = serializers.SerializerMethodField('get_team_increment_points') team_increment_points = serializers.SerializerMethodField("get_team_increment_points")
class Meta: class Meta:
model = models.Milestone model = models.Milestone
@ -44,3 +44,13 @@ class MilestoneSerializer(serializers.ModelSerializer):
def get_team_increment_points(self, obj): def get_team_increment_points(self, obj):
return sum(obj.team_increment_points.values()) return sum(obj.team_increment_points.values())
def validate_name(self, attrs, source):
"""
Check the milestone name is not duplicated in the project
"""
qs = models.Milestone.objects.filter(project=attrs["project"], name=attrs[source])
if qs.exists():
raise serializers.ValidationError("Name duplicated for the project")
return attrs