On retrieve not apply the filter, only check the permissions

remotes/origin/enhancement/email-actions
Jesús Espino 2014-08-19 10:07:20 +02:00
parent e4bfb6ea5a
commit 0d9311613d
3 changed files with 4 additions and 3 deletions

View File

@ -20,6 +20,7 @@
import warnings import warnings
from django.core.exceptions import ValidationError from django.core.exceptions import ValidationError
from django.shortcuts import get_object_or_404
from django.http import Http404 from django.http import Http404
from django.db import transaction as tx from django.db import transaction as tx
@ -120,7 +121,7 @@ class RetrieveModelMixin(object):
Retrieve a model instance. Retrieve a model instance.
""" """
def retrieve(self, request, *args, **kwargs): def retrieve(self, request, *args, **kwargs):
self.object = self.get_object_or_none() self.object = get_object_or_404(self.get_queryset(), **kwargs)
self.check_permissions(request, 'retrieve', self.object) self.check_permissions(request, 'retrieve', self.object)

View File

@ -49,7 +49,7 @@ def test_storage_retrieve(client, data):
] ]
results = helper_test_http_method(client, 'get', url, None, users) results = helper_test_http_method(client, 'get', url, None, users)
assert results == [401, 200, 404] assert results == [404, 200, 404]
def test_storage_update(client, data): def test_storage_update(client, data):

View File

@ -66,7 +66,7 @@ def test_view_storage_entries(client):
# Get by anonymous user # Get by anonymous user
response = client.get(reverse("user-storage-detail", args=[storage11.key])) response = client.get(reverse("user-storage-detail", args=[storage11.key]))
assert response.status_code == 401 assert response.status_code == 404
# Get single entry # Get single entry
client.login(username=user1.username, password=user1.username) client.login(username=user1.username, password=user1.username)