From 0648d601781e7cfd93b314ddb40ee7d32a401bbb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Barrag=C3=A1n=20Merino?= Date: Tue, 12 Nov 2013 19:27:45 +0100 Subject: [PATCH] Fixed bug #88 (id 94): Added comments to the updated emails --- greenmine/base/notifications/api.py | 3 ++- .../emails/update_issue_notification-body-html.jinja | 5 +++++ .../emails/update_issue_notification-body-text.jinja | 9 +++++++-- .../emails/update_milestone_notification-body-html.jinja | 5 +++++ .../emails/update_milestone_notification-body-text.jinja | 9 +++++++-- .../emails/update_task_notification-body-html.jinja | 5 +++++ .../emails/update_task_notification-body-text.jinja | 9 +++++++-- .../emails/update_project_notification-body-html.jinja | 5 +++++ .../emails/update_project_notification-body-text.jinja | 9 +++++++-- .../emails/update_userstory_notification-body-html.jinja | 5 +++++ .../emails/update_userstory_notification-body-text.jinja | 9 +++++++-- 11 files changed, 62 insertions(+), 11 deletions(-) diff --git a/greenmine/base/notifications/api.py b/greenmine/base/notifications/api.py index ecda5939..8b14dedf 100644 --- a/greenmine/base/notifications/api.py +++ b/greenmine/base/notifications/api.py @@ -18,7 +18,8 @@ class NotificationSenderMixin(object): super().post_save(obj, created) users = obj.get_watchers_to_notify(self.request.user) - context = {'changer': self.request.user, 'object': obj} + comment = self.request.DATA.get("comment", None) + context = {'changer': self.request.user, "comment": comment, 'object': obj} if created: self._send_notification_email(self.create_notification_template, diff --git a/greenmine/projects/issues/templates/emails/update_issue_notification-body-html.jinja b/greenmine/projects/issues/templates/emails/update_issue_notification-body-html.jinja index 86fb2433..ea9b6f82 100644 --- a/greenmine/projects/issues/templates/emails/update_issue_notification-body-html.jinja +++ b/greenmine/projects/issues/templates/emails/update_issue_notification-body-html.jinja @@ -10,6 +10,10 @@

Project: {{ object.project.name }}

Issue #{{ object.ref }}: {{ object.subject }}

Updated by {{ changer.get_full_name() }}.

+ {% if comment %} +

Comment {{ comment|linebreaksbr }}

+ {% endif %} + {% if changed_fields %}

Updated fields:

{% for field in changed_fields %} @@ -28,6 +32,7 @@ {% endif %} {% endfor %}
+ {% endif %} diff --git a/greenmine/projects/issues/templates/emails/update_issue_notification-body-text.jinja b/greenmine/projects/issues/templates/emails/update_issue_notification-body-text.jinja index 5c1781bb..51757984 100644 --- a/greenmine/projects/issues/templates/emails/update_issue_notification-body-text.jinja +++ b/greenmine/projects/issues/templates/emails/update_issue_notification-body-text.jinja @@ -4,9 +4,14 @@ - Project: {{ object.project.name }} - Issue #{{ object.ref }}: {{ object.subject }} - Updated by {{ changer.get_full_name() }} +{% if comment %} +Comment: {{ comment|linebreaksbr }} +{% endif %} +{% if changed_fields %} - Updated fields: -{% for field in changed_fields %} + {% for field in changed_fields %} * {{ field.verbose_name}}: from '{{ field.old_value}}' to '{{ field.new_value }}'. -{% endfor %} + {% endfor %} +{% endif %} ** More info at {{ final_url_name }} ({{ final_url }}) ** diff --git a/greenmine/projects/milestones/templates/emails/update_milestone_notification-body-html.jinja b/greenmine/projects/milestones/templates/emails/update_milestone_notification-body-html.jinja index f781b122..617d5127 100644 --- a/greenmine/projects/milestones/templates/emails/update_milestone_notification-body-html.jinja +++ b/greenmine/projects/milestones/templates/emails/update_milestone_notification-body-html.jinja @@ -10,6 +10,10 @@

Project: {{ object.project.name }}

Milestone #{{ object.slug }}: {{ object.name }}

Updated by {{ changer.get_full_name() }}.

+ {% if comment %} +

Comment {{ comment|linebreaksbr }}

+ {% endif %} + {% if changed_fields %}

Updated fields:

{% for field in changed_fields %} @@ -28,6 +32,7 @@ {% endif %} {% endfor %}
+ {% endif %} diff --git a/greenmine/projects/milestones/templates/emails/update_milestone_notification-body-text.jinja b/greenmine/projects/milestones/templates/emails/update_milestone_notification-body-text.jinja index 4c437d3b..d3e8331a 100644 --- a/greenmine/projects/milestones/templates/emails/update_milestone_notification-body-text.jinja +++ b/greenmine/projects/milestones/templates/emails/update_milestone_notification-body-text.jinja @@ -4,9 +4,14 @@ - Project: {{ object.project.name }} - Milestone #{{ object.slug }}: {{ object.name }} - Updated by {{ changer.get_full_name() }} +{% if comment %} +Comment: {{ comment|linebreaksbr }} +{% endif %} +{% if changed_fields %} - Updated fields: -{% for field in changed_fields %} + {% for field in changed_fields %} * {{ field.verbose_name}}: from '{{ field.old_value}}' to '{{ field.new_value }}'. -{% endfor %} + {% endfor %} +{% endif %} ** More info at {{ final_url_name }} ({{ final_url }}) ** diff --git a/greenmine/projects/tasks/templates/emails/update_task_notification-body-html.jinja b/greenmine/projects/tasks/templates/emails/update_task_notification-body-html.jinja index 53cb9849..e1460cb7 100644 --- a/greenmine/projects/tasks/templates/emails/update_task_notification-body-html.jinja +++ b/greenmine/projects/tasks/templates/emails/update_task_notification-body-html.jinja @@ -10,6 +10,10 @@

Project: {{ object.project.name }}

Task #{{ object.ref }}: {{ object.subject }}

Updated by {{ changer.get_full_name() }}.

+ {% if comment %} +

Comment {{ comment|linebreaksbr }}

+ {% endif %} + {% if changed_fields %}

Updated fields:

{% for field in changed_fields %} @@ -28,6 +32,7 @@ {% endif %} {% endfor %}
+ {% endif %} diff --git a/greenmine/projects/tasks/templates/emails/update_task_notification-body-text.jinja b/greenmine/projects/tasks/templates/emails/update_task_notification-body-text.jinja index 158612b2..fd4dc589 100644 --- a/greenmine/projects/tasks/templates/emails/update_task_notification-body-text.jinja +++ b/greenmine/projects/tasks/templates/emails/update_task_notification-body-text.jinja @@ -4,9 +4,14 @@ - Project: {{ object.project.name }} - Task #{{ object.ref }}: {{ object.subject }} - Updated by {{ changer.get_full_name() }} +{% if comment %} +Comment: {{ comment|linebreaksbr }} +{% endif %} +{% if changed_fields %} - Updated fields: -{% for field in changed_fields %} + {% for field in changed_fields %} * {{ field.verbose_name}}: from '{{ field.old_value}}' to '{{ field.new_value }}'. -{% endfor %} + {% endfor %} +{% endif %} ** More info at {{ final_url_name }} ({{ final_url }}) ** diff --git a/greenmine/projects/templates/emails/update_project_notification-body-html.jinja b/greenmine/projects/templates/emails/update_project_notification-body-html.jinja index c0ced8cd..78244c89 100644 --- a/greenmine/projects/templates/emails/update_project_notification-body-html.jinja +++ b/greenmine/projects/templates/emails/update_project_notification-body-html.jinja @@ -9,6 +9,10 @@

Project #{{ object.slug }}: {{ object.name }}

Updated by {{ changer.get_full_name() }}.

+ {% if comment %} +

Comment {{ comment|linebreaksbr }}

+ {% endif %} + {% if changed_fields %}

Updated fields:

{% for field in changed_fields %} @@ -27,6 +31,7 @@ {% endif %} {% endfor %}
+ {% endif %} diff --git a/greenmine/projects/templates/emails/update_project_notification-body-text.jinja b/greenmine/projects/templates/emails/update_project_notification-body-text.jinja index 5e88c59b..a201e7ec 100644 --- a/greenmine/projects/templates/emails/update_project_notification-body-text.jinja +++ b/greenmine/projects/templates/emails/update_project_notification-body-text.jinja @@ -3,9 +3,14 @@ - Project #{{ object.slug }}: {{ object.name }} - Updated by {{ changer.get_full_name() }} +{% if comment %} +Comment: {{ comment|linebreaksbr }} +{% endif %} +{% if changed_fields %} - Updated fields: -{% for field in changed_fields %} + {% for field in changed_fields %} * {{ field.verbose_name}}: from '{{ field.old_value}}' to '{{ field.new_value }}'. -{% endfor %} + {% endfor %} +{% endif %} ** More info at {{ final_url_name }} ({{ final_url }}) ** diff --git a/greenmine/projects/userstories/templates/emails/update_userstory_notification-body-html.jinja b/greenmine/projects/userstories/templates/emails/update_userstory_notification-body-html.jinja index ed0ab8f9..770b8d52 100644 --- a/greenmine/projects/userstories/templates/emails/update_userstory_notification-body-html.jinja +++ b/greenmine/projects/userstories/templates/emails/update_userstory_notification-body-html.jinja @@ -10,6 +10,10 @@

Project: {{ object.project.name }}

US #{{ object.ref }}: {{ object.subject }}

Updated by {{ changer.get_full_name() }}.

+ {% if comment %} +

Comment {{ comment|linebreaksbr }}

+ {% endif %} + {% if changed_fields %}

Updated fields:

{% for field in changed_fields %} @@ -28,6 +32,7 @@ {% endif %} {% endfor %}
+ {% endif %} diff --git a/greenmine/projects/userstories/templates/emails/update_userstory_notification-body-text.jinja b/greenmine/projects/userstories/templates/emails/update_userstory_notification-body-text.jinja index 3a444cc5..3c7b46bf 100644 --- a/greenmine/projects/userstories/templates/emails/update_userstory_notification-body-text.jinja +++ b/greenmine/projects/userstories/templates/emails/update_userstory_notification-body-text.jinja @@ -4,9 +4,14 @@ - Project: {{ object.project.name }} - US #{{ object.ref }}: {{ object.subject }} - Updated by {{ changer.get_full_name() }} +{% if comment %} +Comment: {{ comment|linebreaksbr }} +{% endif %} +{% if changed_fields %} - Updated fields: -{% for field in changed_fields %} + {% for field in changed_fields %} * {{ field.verbose_name}}: from '{{ field.old_value}}' to '{{ field.new_value }}'. -{% endfor %} + {% endfor %} +{% endif %} ** More info at {{ final_url_name }} ({{ final_url }}) **