From 6df6e552b7150826fdbccb5e12a30199c6c59fe7 Mon Sep 17 00:00:00 2001 From: "Dustin C. Hatch" Date: Tue, 11 Oct 2022 21:58:43 -0500 Subject: [PATCH] longhorn: Remove node selector labels I originally added the `du5t1n.me/storage` label to the x86_64 nodes and configured Longhorn to only run on nodes with those labels because I thought that was the correct way to control where volume replicas are stored. It turns out that this was incorrect, as it prevented Longhorn from running on non-matching nodes entirely. Thus, any machine that was not so labeled could not access any Longhorn storage volumes. The correct way to limit where Longhorn stores volume replicas is to enable the `create-default-disk-labeled-nodes` setting. With this setting enabled, Longhorn will run on all nodes, but will not create "disks" on them unless they have the `node.longhorn.io/create-default-disk` label set to `true`. Nodes that do not have "disks" will not store volume replicas, but will run the other Longhorn components and can therefore access Longhorn volumes. Note that changing the "default settings" ConfigMap does not change the setting once Longhorn has been deployed. To update the setting on an existing installation, the setting has to be changed explicitly: ```sh kubectl get setting -n longhorn-system -o json \ create-default-disk-labeled-nodes \ | jq '.value="true"' \ | kubectl apply -f - ``` --- storage/longhorn.yaml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/storage/longhorn.yaml b/storage/longhorn.yaml index 5ea4d28..ce9c4da 100644 --- a/storage/longhorn.yaml +++ b/storage/longhorn.yaml @@ -63,8 +63,7 @@ metadata: app.kubernetes.io/version: v1.3.0 data: default-setting.yaml: |- - system-managed-components-node-selector: - du5t1n.me/storage=longhorn + create-default-disk-labeled-nodes: true --- # Source: longhorn/templates/storageclass.yaml apiVersion: v1 @@ -3457,8 +3456,6 @@ spec: app.kubernetes.io/version: v1.3.0 app: longhorn-manager spec: - nodeSelector: - du5t1n.me/storage: longhorn initContainers: - name: wait-longhorn-admission-webhook image: longhornio/longhorn-manager:v1.3.0 @@ -3556,8 +3553,6 @@ spec: app.kubernetes.io/version: v1.3.0 app: longhorn-driver-deployer spec: - nodeSelector: - du5t1n.me/storage: longhorn initContainers: - name: wait-longhorn-manager image: longhornio/longhorn-manager:v1.3.0