xactfetch: Suppress asyncio InvalidStateError
dustin/xactfetch/pipeline/head This commit looks good
Details
dustin/xactfetch/pipeline/head This commit looks good
Details
There is currently a [bug][0] in the Python Playwright API that causes _asyncio_ to raise an `InvalidStateError` occasionally when the `PlaywrightContextManager` exits. This causes the program to exit with a nonzero return code, even though it actually completed successfully, which will cause the Job to be retried. To avoid this, we can catch and ignore the spurious exception. I've reorganized the code a bit here because we have to wrap the whole `with` block in the `try`/`except`; moving the contents of the block into a function keeps the indentation level from getting out of control. [0]: https://github.com/microsoft/playwright-python/issues/2238
parent
3ff18d1042
commit
48708af68e
66
xactfetch.py
66
xactfetch.py
|
@ -13,7 +13,7 @@ from types import TracebackType
|
||||||
from typing import Any, Optional, Type
|
from typing import Any, Optional, Type
|
||||||
|
|
||||||
import httpx
|
import httpx
|
||||||
from playwright.async_api import Page
|
from playwright.async_api import Playwright, Page
|
||||||
from playwright.async_api import async_playwright
|
from playwright.async_api import async_playwright
|
||||||
|
|
||||||
|
|
||||||
|
@ -702,10 +702,7 @@ class Chase:
|
||||||
return secret.decode()
|
return secret.decode()
|
||||||
|
|
||||||
|
|
||||||
async def amain() -> None:
|
async def fetch_transactions(pw: Playwright, secrets: SecretsClient) -> bool:
|
||||||
logging.basicConfig(level=logging.DEBUG)
|
|
||||||
secrets = SecretsClient()
|
|
||||||
await secrets.connect()
|
|
||||||
log.debug('Getting Firefly III access token')
|
log.debug('Getting Firefly III access token')
|
||||||
token = (await secrets.get_secret('firefly.token')).decode()
|
token = (await secrets.get_secret('firefly.token')).decode()
|
||||||
import_secret = (
|
import_secret = (
|
||||||
|
@ -720,31 +717,40 @@ async def amain() -> None:
|
||||||
)
|
)
|
||||||
end_date = datetime.date.today() - datetime.timedelta(days=1)
|
end_date = datetime.date.today() - datetime.timedelta(days=1)
|
||||||
failed = False
|
failed = False
|
||||||
async with async_playwright() as pw, secrets:
|
browser = await pw.chromium.launch(headless=False)
|
||||||
browser = await pw.chromium.launch(headless=False)
|
context = await browser.new_context()
|
||||||
context = await browser.new_context()
|
await context.tracing.start(screenshots=True, snapshots=True)
|
||||||
await context.tracing.start(screenshots=True, snapshots=True)
|
page = await context.new_page()
|
||||||
page = await context.new_page()
|
banks = sys.argv[1:] or list(ACCOUNTS.keys())
|
||||||
banks = sys.argv[1:] or list(ACCOUNTS.keys())
|
if 'commerce' in banks:
|
||||||
if 'commerce' in banks:
|
if not await download_commerce(
|
||||||
if not await download_commerce(
|
page, secrets, end_date, token, importer
|
||||||
page, secrets, end_date, token, importer
|
):
|
||||||
):
|
failed = True
|
||||||
failed = True
|
if 'chase' in banks:
|
||||||
if 'chase' in banks:
|
if not await download_chase(page, secrets, end_date, token, importer):
|
||||||
if not await download_chase(
|
failed = True
|
||||||
page, secrets, end_date, token, importer
|
if failed:
|
||||||
):
|
await context.tracing.stop(path='trace.zip')
|
||||||
failed = True
|
with open('trace.zip', 'rb') as f:
|
||||||
if failed:
|
await ntfy(
|
||||||
await context.tracing.stop(path='trace.zip')
|
'Downloading one or more transaction lists failed.',
|
||||||
with open('trace.zip', 'rb') as f:
|
attach=f.read(),
|
||||||
await ntfy(
|
filename='trace.zip',
|
||||||
'Downloading one or more transaction lists failed.',
|
)
|
||||||
attach=f.read(),
|
return failed
|
||||||
filename='trace.zip',
|
|
||||||
)
|
|
||||||
raise SystemExit(1 if failed else 0)
|
async def amain() -> None:
|
||||||
|
logging.basicConfig(level=logging.DEBUG)
|
||||||
|
|
||||||
|
async with SecretsClient() as secrets:
|
||||||
|
try:
|
||||||
|
async with async_playwright() as pw:
|
||||||
|
failed = await fetch_transactions(pw, secrets)
|
||||||
|
raise SystemExit(1 if failed else 0)
|
||||||
|
except asyncio.exceptions.InvalidStateError:
|
||||||
|
log.debug('Ignoring exception: %s', exc_info=sys.exc_info())
|
||||||
|
|
||||||
|
|
||||||
def main():
|
def main():
|
||||||
|
|
Loading…
Reference in New Issue